RSS replies to a user #111 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umputun
reviewed
Jul 9, 2018
backend/app/rest/api/rss.go
Outdated
| log.Printf("[DEBUG] get rss replies to user %s for site %s", userID, siteID) | ||
|
|
||
| data, err := s.Cache.Get(cache.Key(cache.URLKey(r), siteID, userID), func() ([]byte, error) { | ||
| comments, e := s.DataService.Last(siteID, 100) |
There was a problem hiding this comment.
pls make a const for this, maxLastForReply or smth like this
backend/app/rest/api/rss.go
Outdated
|
|
||
| replies := []store.Comment{} | ||
| for _, c := range comments { | ||
| if len(replies) > maxRssItems || c.Timestamp.Add(30*time.Minute).Before(time.Now()) { |
There was a problem hiding this comment.
same story as above - MaxReplyMins
backend/app/rest/api/rss.go
Outdated
| break | ||
| } | ||
| if c.ParentID != "" && !c.Deleted && c.User.ID != userID { // not interested replies to yourself | ||
| pc, e := s.DataService.Get(c.Locator, c.ParentID) |
There was a problem hiding this comment.
this made linter sad "app/rest/api/rss.go:111::warning: declaration of "e" shadows declaration at app/rest/api/rss.go:99 (vetshadow)"
|
Added consts and fixed linter warning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
/rss/reply?user=userID&site=siteIDendpoint. It retrieves last 100 comments for sitesiteIDand for each comment reads parent to determine is it reply touserIDor not. Stops iterate when max replies are found or comment were published later than 30 minutes. Skips replies when user replies to himself.relates to #111