Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: anon cannot request data removal #1463

Merged
merged 1 commit into from
Aug 22, 2022
Merged

fix: anon cannot request data removal #1463

merged 1 commit into from
Aug 22, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Aug 22, 2022

Resolves #1460

@akellbl4 akellbl4 requested a review from umputun as a code owner August 22, 2022 03:54
@github-actions
Copy link

github-actions bot commented Aug 22, 2022

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 72.4 KB (+0.01% 🔺)
public/remark.css 8.21 KB (+0.02% 🔺)
public/last-comments.mjs 35.54 KB (-0.01% 🔽)
public/last-comments.css 3.79 KB (+0.03% 🔺)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

@akellbl4 akellbl4 force-pushed the anonym-cant-remove branch 3 times, most recently from 0a911da to 93766df Compare August 22, 2022 04:02
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #1463 (6c30e17) into master (b47b6c4) will decrease coverage by 28.69%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #1463       +/-   ##
===========================================
- Coverage   86.83%   58.14%   -28.70%     
===========================================
  Files           8      131      +123     
  Lines         509     2910     +2401     
  Branches       67      743      +676     
===========================================
+ Hits          442     1692     +1250     
- Misses          0     1214     +1214     
+ Partials       67        4       -63     
Impacted Files Coverage Δ
...d/apps/remark42/app/components/profile/profile.tsx 78.50% <100.00%> (ø)
frontend/packages/api/lib/fetcher.ts
frontend/packages/api/clients/index.ts
frontend/packages/api/lib/cookies.ts
frontend/packages/api/clients/admin.ts
frontend/packages/api/index.ts
frontend/packages/api/clients/auth.ts
frontend/packages/api/consts.ts
frontend/packages/api/clients/public.ts
...ontend/apps/remark42/app/utils/get-hidden-users.ts 100.00% <0.00%> (ø)
... and 130 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Sponsor Collaborator

@paskal paskal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button disappeared, as expected.

@akellbl4 akellbl4 merged commit dc048ef into master Aug 22, 2022
@akellbl4 akellbl4 deleted the anonym-cant-remove branch August 22, 2022 18:42
@paskal paskal added this to the v1.10.2 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] do not show "Request my data removal" for anonymous users
3 participants