Bump go modules, make auth dev hostname customisable #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this change is potentially breaking (well, a little bit) and may need some explanation in docs. The only use case I can think of - is some local testing user sets a fake domain in remark_url but want dev auth to go to 127.0.0.1. I don't think such a rare/exotic case warrants an extra parameter, but maybe we want to indicate in docs what prior to version x.y.z.t this dev authg always went to 127.0.0.1 |
paskal
force-pushed
the
paskal/bump_modules
branch
from
84990d8
to
0a04fe9
Compare
|
@umputun I've updated development documentation as well as development docker-compose files; please review once more. |
After this commit, dev auth would start working with the `REMARK_URL` hostname instead of the previously hardcoded 127.0.0.1. Breaks development setup where `REMARK_URL` was set to a non-standard value and dev auth was running on 127.0.0.1 and working, as, after that change, it would stop working.
paskal
force-pushed
the
paskal/bump_modules
branch
from
0a04fe9
to
90d5e7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this commit, dev auth would start working with the
REMARK_URLhostname instead of the previously hardcoded 127.0.0.1.Breaks development setup where
REMARK_URLwas set to a non-standard value and dev auth was running on 127.0.0.1 and working, as, after that change, it would stop working.