Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix makefile and dockerfile #1492

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Fix makefile and dockerfile #1492

merged 1 commit into from
Sep 17, 2022

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Sep 15, 2022

Here are multiple changes to commands run by Makefile based on my attempts to run it on an Oracle Linux machine with the latest Docker.

The only known problem left is happening with make bin, make dockerx and make release:

[opc@terrty-net ~/remark42]$ make bin
Step 7/29 : RUN --mount=type=cache,id=pnpm,target=/root/.pnpm-store/v3 pnpm i
the --mount option requires BuildKit. Refer to https://docs.docker.com/go/buildkit/ to learn how to build images with BuildKit enabled
make: *** [Makefile:7: bin] Error 1

akellbl4
akellbl4 previously approved these changes Sep 15, 2022
Here are multiple changes to commands run by Makefile based on my
attempts to run it on an Oracle Linux machine with the latest Docker.
@paskal paskal changed the title Fix makefile and docker-compose mentions Fix makefile and dockerfile Sep 17, 2022
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umputun umputun merged commit c0e8520 into master Sep 17, 2022
@umputun umputun deleted the paskal/fix_makefile branch September 17, 2022 18:05
@paskal paskal added this to the v1.10.2 milestone Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants