Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix iframe resize on auth dropdown opening #1503

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Oct 1, 2022

No description provided.

@akellbl4 akellbl4 requested a review from umputun as a code owner October 1, 2022 18:34
@codecov
Copy link

codecov bot commented Oct 1, 2022

Codecov Report

Base: 58.12% // Head: 58.07% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (785f235) compared to base (4733ad8).
Patch coverage: 4.76% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1503      +/-   ##
==========================================
- Coverage   58.12%   58.07%   -0.06%     
==========================================
  Files         131      131              
  Lines        2909     2910       +1     
  Branches      743      743              
==========================================
- Hits         1691     1690       -1     
+ Misses       1214     1089     -125     
- Partials        4      131     +127     
Impacted Files Coverage Δ
...rontend/apps/remark42/app/components/root/root.tsx 0.00% <0.00%> (ø)
...nd/apps/remark42/app/components/auth/auth.hooks.ts 92.30% <100.00%> (-0.10%) ⬇️
frontend/apps/remark42/app/embed.ts 0.00% <0.00%> (ø)
frontend/apps/remark42/app/counter.ts 0.00% <0.00%> (ø)
frontend/apps/remark42/app/profile.ts 0.00% <0.00%> (ø)
frontend/apps/remark42/app/remark.tsx 0.00% <0.00%> (ø)
frontend/apps/remark42/app/deleteme.ts 0.00% <0.00%> (ø)
frontend/apps/remark42/app/utils/cmpRef.ts 50.00% <0.00%> (ø)
frontend/apps/remark42/app/common/cookies.ts 23.80% <0.00%> (ø)
frontend/apps/remark42/app/last-comments.tsx 0.00% <0.00%> (ø)
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Oct 1, 2022

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 72.54 KB (+0.03% 🔺)
public/remark.css 8.12 KB (0%)
public/last-comments.mjs 35.63 KB (+0.01% 🔺)
public/last-comments.css 3.72 KB (-0.03% 🔽)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

@umputun umputun merged commit 363e05d into master Oct 1, 2022
@umputun umputun deleted the fix-iframe-resize branch October 1, 2022 23:34
@paskal paskal added this to the v1.10.2 milestone Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants