Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no_footer option #1511

Merged
merged 1 commit into from Oct 26, 2022
Merged

Support no_footer option #1511

merged 1 commit into from Oct 26, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 10, 2022

#1305

but I wasn't able to test that, because looks like this guide https://remark42.com/docs/contributing/frontend/ is outdated.

@ghost ghost requested a review from umputun as a code owner October 10, 2022 22:42
@paskal paskal added this to the v1.11.1 milestone Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 58.07% // Head: 57.95% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (4cbb22b) compared to base (53cc370).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1511      +/-   ##
==========================================
- Coverage   58.07%   57.95%   -0.12%     
==========================================
  Files         131      131              
  Lines        2910     2916       +6     
  Branches      743      745       +2     
==========================================
  Hits         1690     1690              
- Misses       1089     1094       +5     
- Partials      131      132       +1     
Impacted Files Coverage Δ
...rontend/apps/remark42/app/components/root/root.tsx 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@umputun umputun merged commit 984fbde into umputun:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants