Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update fe contributing documentation and get dev commands in order #1538

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

akellbl4
Copy link
Collaborator

Resolves #1530

Documentation wasn't matching reality.
Updated run commands and docs.

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 57.95% // Head: 57.95% // No change to project coverage 👍

Coverage data is based on head (6840bd3) compared to base (984fbde).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1538   +/-   ##
=======================================
  Coverage   57.95%   57.95%           
=======================================
  Files         131      131           
  Lines        2916     2916           
  Branches      745      745           
=======================================
  Hits         1690     1690           
  Misses       1094     1094           
  Partials      132      132           
Impacted Files Coverage Δ
...rontend/apps/remark42/app/components/root/root.tsx 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 73.02 KB (+0.01% 🔺)
public/remark.css 8.12 KB (-0.02% 🔽)
public/last-comments.mjs 35.82 KB (0%)
public/last-comments.css 3.72 KB (0%)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

@paskal paskal added this to the v1.11.1 milestone Nov 30, 2022
@umputun umputun merged commit 6fe373d into master Nov 30, 2022
@umputun umputun deleted the akellbl4/update-fe-contributing branch November 30, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pnpm start:app does not work (on windows?)
3 participants