refac: use resize observer instead of mutation observer #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akellbl4
changed the title
akellbl4
commented
Dec 4, 2022
| const observer = new ResizeObserver(updateIframeHeight); | ||
|
|
||
| updateIframeHeight(); | ||
| observer.observe(document.body); |
There was a problem hiding this comment.
Not sure if it's a good idea to listen on body.
size-limit report 📦
|
Codecov ReportBase: 58.04% // Head: 58.02% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1547 +/- ##
==========================================
- Coverage 58.04% 58.02% -0.03%
==========================================
Files 131 131
Lines 2920 2911 -9
Branches 746 743 -3
==========================================
- Hits 1695 1689 -6
+ Misses 1093 1091 -2
+ Partials 132 131 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
akellbl4
force-pushed
the
akellbl4/refactor-resizing
branch
from
7c90435
to
9d7a807
Compare
Mavrin
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor resizing mechanism with more sutable browser API.