Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple auth provider frontend support #1560

Merged
merged 2 commits into from
Jan 8, 2023
Merged

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Jan 4, 2023

With distinct logos for light and dark theme from https://devimages-cdn.apple.com/design/resources/download/Logo-Sign-in-with-Apple.dmg

image

image

Screenshot 2023-01-04 at 10 37 13

Logos should be adapted as now the logo is too small. However, everything seems to be working. Resolves #906.

@paskal paskal added the frontend label Jan 4, 2023
@paskal paskal requested a review from umputun as a code owner January 4, 2023 06:31
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 58.02% // Head: 62.35% // Increases project coverage by +4.32% 🎉

Coverage data is based on head (2785993) compared to base (067a8bc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1560      +/-   ##
==========================================
+ Coverage   58.02%   62.35%   +4.32%     
==========================================
  Files         131      139       +8     
  Lines        2911     3421     +510     
  Branches      736      803      +67     
==========================================
+ Hits         1689     2133     +444     
+ Misses       1091     1090       -1     
- Partials      131      198      +67     
Impacted Files Coverage Δ
frontend/apps/remark42/app/common/types.ts 100.00% <ø> (ø)
...k42/app/components/auth/components/oauth.consts.ts 100.00% <ø> (ø)
frontend/packages/api/clients/index.ts 96.42% <100.00%> (ø)
frontend/packages/api/lib/cookies.ts 63.63% <0.00%> (ø)
frontend/packages/api/index.ts 100.00% <0.00%> (ø)
frontend/packages/api/lib/fetcher.ts 80.85% <0.00%> (ø)
frontend/packages/api/consts.ts 63.63% <0.00%> (ø)
frontend/packages/api/clients/auth.ts 82.97% <0.00%> (ø)
frontend/packages/api/clients/public.ts 92.81% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paskal paskal requested review from akellbl4 and Mavrin January 4, 2023 06:33
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 72.76 KB (+0.06% 🔺)
public/remark.css 8.12 KB (0%)
public/last-comments.mjs 35.67 KB (0%)
public/last-comments.css 3.72 KB (0%)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

Mavrin
Mavrin previously approved these changes Jan 6, 2023
@paskal paskal added this to the v1.11.3 milestone Jan 6, 2023
@umputun umputun merged commit 6ac7503 into master Jan 8, 2023
@umputun umputun deleted the paskal/apple_frontend branch January 8, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sign in with Apple
4 participants