Cleanup of the frontend code

[paskal]

• replace undocumented substr with substring
• remove unused code
• inline a few variables
• simplify ifs when possible
• improve saveCollapsedComments documentation
• cleanup the unused imports
• remove unused variables and types

[codecov]

Codecov Report

Base: 58.05% // Head: 58.45% // Increases project coverage by +0.40% 🎉

Coverage data is based on head (3d12f07) compared to base (82f27e6).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1563      +/-   ##
==========================================
+ Coverage   58.05%   58.45%   +0.40%     
==========================================
  Files         131      128       -3     
  Lines        2911     2879      -32     
  Branches      736      729       -7     
==========================================
- Hits         1690     1683       -7     
+ Misses       1090     1070      -20     
+ Partials      131      126       -5     

Impacted Files	Coverage Δ
frontend/apps/remark42/app/common/api.ts	72.09% <ø> (-0.64%)	⬇️
frontend/apps/remark42/app/common/cookies.ts	21.05% <ø> (-2.76%)	⬇️
frontend/apps/remark42/app/common/types.ts	100.00% <ø> (ø)
...ribe-by-email/comment-form__subscribe-by-email.tsx	90.59% <ø> (ø)
...rontend/apps/remark42/app/components/root/root.tsx	0.00% <ø> (ø)
...apps/remark42/app/components/settings/settings.tsx	0.00% <0.00%> (ø)
...ontend/apps/remark42/app/utils/replaceSelection.ts	50.00% <0.00%> (ø)
frontend/apps/remark42/app/common/fetcher.ts	94.82% <100.00%> (-0.09%)	⬇️
...nd/apps/remark42/app/components/auth/auth.hooks.ts	89.74% <100.00%> (-1.29%)	⬇️
...ark42/app/components/comment-form/comment-form.tsx	51.70% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

size-limit report 📦

Path	Size
public/embed.mjs	2.03 KB (0%)
public/remark.mjs	72.67 KB (-0.12% 🔽)
public/remark.css	8.12 KB (-0.02% 🔽)
public/last-comments.mjs	35.62 KB (-0.14% 🔽)
public/last-comments.css	3.72 KB (-0.03% 🔽)
public/deleteme.mjs	12.04 KB (-0.03% 🔽)
public/counter.mjs	749 B (0%)

[akellbl4]

@paskal I like those changes. I wrote few points which we should fix before merging it.

[akellbl4]

I just realized that you tried to address #1321. I'd say it's less than ideal way of addressing it, so I'd rather leave ts-ignore because assertions is nothing better that ignores because types are still unsafe.

[akellbl4]

@paskal nice job!