Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in frontend code #1564

Merged
merged 1 commit into from
Jan 8, 2023
Merged

Fix typos in frontend code #1564

merged 1 commit into from
Jan 8, 2023

Conversation

paskal
Copy link
Sponsor Collaborator

@paskal paskal commented Jan 8, 2023

Also, little style changes in frontend development documentation and add a missing comma in the privacy policy.

@paskal paskal requested review from Mavrin and akellbl4 January 8, 2023 12:51
@paskal paskal requested a review from umputun as a code owner January 8, 2023 12:51
@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Base: 62.35% // Head: 58.05% // Decreases project coverage by -4.29% ⚠️

Coverage data is based on head (00a2d15) compared to base (6ac7503).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1564      +/-   ##
==========================================
- Coverage   62.35%   58.05%   -4.30%     
==========================================
  Files         139      131       -8     
  Lines        3421     2911     -510     
  Branches      803      736      -67     
==========================================
- Hits         2133     1690     -443     
  Misses       1090     1090              
+ Partials      198      131      -67     
Impacted Files Coverage Δ
frontend/apps/remark42/app/common/constants.ts 90.00% <ø> (ø)
frontend/apps/remark42/app/common/fetcher.ts 94.91% <ø> (ø)
...d/apps/remark42/app/components/comment/comment.tsx 62.38% <ø> (ø)
...d/apps/remark42/app/components/profile/profile.tsx 78.50% <ø> (ø)
frontend/apps/remark42/app/store/thread/utils.ts 68.75% <ø> (ø)
frontend/apps/remark42/app/utils/post-message.ts 50.00% <ø> (ø)
frontend/packages/api/lib/cookies.ts
frontend/packages/api/clients/admin.ts
frontend/packages/api/consts.ts
frontend/packages/api/index.ts
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 72.76 KB (0%)
public/remark.css 8.12 KB (0%)
public/last-comments.mjs 35.67 KB (-0.01% 🔽)
public/last-comments.css 3.72 KB (-0.03% 🔽)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

@umputun umputun merged commit 82f27e6 into master Jan 8, 2023
@umputun umputun deleted the paskal/frontend_typos branch January 8, 2023 18:30
@paskal paskal added this to the v1.11.3 milestone Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants