Skip confirmation step on email subscription #1646
Conversation
When user logged in with the same email he tries to subscribe
…-sub-confirm # Conflicts: # frontend/apps/remark42/app/common/api.ts
set autoConfirm param to make it work
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1646 +/- ##
==========================================
+ Coverage 58.63% 58.71% +0.08%
==========================================
Files 128 128
Lines 2877 2885 +8
Branches 730 697 -33
==========================================
+ Hits 1687 1694 +7
- Misses 1065 1187 +122
+ Partials 125 4 -121
☔ View full report in Codecov by Sentry. |
|
#1645 changes are also here. They were required for this change and I was forced to merge that branch into this one. |
There was a problem hiding this comment.
Here is what I get after trying to subscribe with the same email once I've already subscribed (but interface didn't update for some reason):
The core functionality is fine, but I wonder if we can handle this code 409 edge case differently so that interface will just update with "you've subscribed" instead of showing me the error before I reload the page.
prevStep is not used anywhere else and because of it influences output text (haveSubscribed), have changed it to more intuitive justSubscribed variable
…' into 1174-email-user-skip-sub-confirm
|
@paskal Could you please review it again? |
|
Works like a charm! Please rebase and we'll merge it. |
When user is logged in with the same email he tries to subscribe
According to #1174