Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Telegram QR styling #1647

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Telegram QR styling #1647

merged 3 commits into from
Jun 28, 2023

Conversation

Jaskon
Copy link
Contributor

@Jaskon Jaskon commented Jun 25, 2023

Issue #1622

Changes:

  • 1/1 aspect ratio
  • white border around (for easier scan)

Before:
Screenshot 2023-06-27 at 22 00 13

After:
Screenshot 2023-06-27 at 22 14 36

- 1/1 aspect ratio
- white border around (for easier scan)
@Jaskon Jaskon requested a review from umputun as a code owner June 25, 2023 15:25
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (07667c8) 58.63% compared to head (d244240) 58.63%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1647    +/-   ##
========================================
  Coverage   58.63%   58.63%            
========================================
  Files         128      128            
  Lines        2877     2877            
  Branches      730      695    -35     
========================================
  Hits         1687     1687            
- Misses       1065     1186   +121     
+ Partials      125        4   -121     

see 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Jaskon
Copy link
Contributor Author

Jaskon commented Jun 25, 2023

What is the Size limit error about?
Do I need to open some permissions in my fork to fix that?

@paskal
Copy link
Sponsor Collaborator

paskal commented Jun 27, 2023

Can you please post screenshots before and after the change?
As for the size limit, it's defined here so you need to alter it in this PR.

@umputun umputun merged commit d3fdd7b into umputun:master Jun 28, 2023
9 checks passed
@paskal paskal added this to the v1.12.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants