Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation to support Caddy V2 #1657

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Update documentation to support Caddy V2 #1657

merged 3 commits into from
Jul 21, 2023

Conversation

tardisx
Copy link
Contributor

@tardisx tardisx commented Jul 18, 2023

  • Change Caddy example config to be compatible with Caddy V2 config format
  • Caddy V2 was released in 2020 and most new users are likely to be using that
  • Existing config snippet is not compatible with V2 at all

@tardisx
Update index.md
154b286 
Change Caddy example config to the current V2 config.
@tardisx
Simplify config
ed11600
@tardisx tardisx requested a review from umputun as a code owner July 18, 2023 13:07
umputun
umputun reviewed Jul 18, 2023
View reviewed changes
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. Maybe we better keep the old one under "caddy version 1" and add your change with "caddy version 2" ?

Proxy is such a thing people may use for a long time without upgrading

@tardisx
Copy link
Contributor Author

tardisx commented Jul 19, 2023

thx. Maybe we better keep the old one under "caddy version 1" and add your change with "caddy version 2" ?

Proxy is such a thing people may use for a long time without upgrading

Excellent point, I have updated the PR.

umputun
umputun approved these changes Jul 21, 2023
View reviewed changes
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@umputun umputun merged commit 235f0da into umputun:master Jul 21, 2023
1 check passed
@paskal paskal added this to the v1.12.0 milestone Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tardisx @umputun @paskal