Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frontend support for anonymous user login #295

Merged
merged 2 commits into from
Apr 9, 2019

Conversation

Reeywhaar
Copy link
Collaborator

to #279

depends on #281

Adds support for anonymous user login

anon-screencap

@umputun
Copy link
Owner

umputun commented Mar 24, 2019

This is a scary looking one ;) It seems to include all refactoring, i.e. on top of #281. I think we should finalize refactoring and rebase on top if it

@umputun
Copy link
Owner

umputun commented Mar 24, 2019

another thing on my side - probably it makes sense to set dev-style avatar (identicon) for anonymous users

@Reeywhaar
Copy link
Collaborator Author

Yep, when refactoring will be merged I think github should start to show commits on base of refactoring top.

I've made anonymous avatar in style of lost avatar, but yeah, better to show different icons.

@umputun
Copy link
Owner

umputun commented Mar 24, 2019

Can you add anon to your demo page on go-pkgz/auth pls? This way I will able to see it in action

@Reeywhaar
Copy link
Collaborator Author

@umputun let me know when you add identicon support. I need to handle it as well, as now in case of anonymous login predefined icon displayed.

@umputun
Copy link
Owner

umputun commented Mar 24, 2019

should be in place - released v0.5.0 of pkgz/auth and updated dependency here.

@Reeywhaar
Copy link
Collaborator Author

Updated to use identicons.

@umputun
Copy link
Owner

umputun commented Mar 31, 2019

ping ping. @igoradamenko / @Guria - any chance you can review this one, pleeease?

@Reeywhaar
Copy link
Collaborator Author

Well, I'm myself busy until next weekend probably, so #297, #291, #285 etc... will have to wait if no one wishes to participate.

@Guria
Copy link
Collaborator

Guria commented Apr 1, 2019

@umputun will take a look this week

@umputun umputun merged commit 08bc105 into umputun:master Apr 9, 2019
@Reeywhaar Reeywhaar deleted the feature/front-anon-login branch April 10, 2019 23:18
@paskal paskal added this to the v1.3 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants