-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some DB errors is not errors #41
Conversation
one of tests is failed. but this test also failed on master branch ( |
@umputun please show me error cause. |
until we switch to public CI (see #14) the only way to see what failed the build the same way as CI is to run docker build.
|
I'm not sure what the purpose of this PR. What exactly the problem it's trying to solve by adding all this code? I mean, I get what it's trying to achieve is to differentiate store errors with more granularity, but don't get why all of this even needed in the first place. Do you have any particular use-case in mind? To me, requests for non-exiting id, bucket, and the user feels like a good fit for "bad request". |
I do not speak English well. I hope you understand me: close until #14 )) |
get comment by id on non exists id or non exists bucket:
HTTP 400 + err
=>HTTP 404
get comments list on non exists page bucket, userID bucket:
HTTP 400 + err
=>HTTP 200 + blank comment list "[]"