Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic Travis CI configuration. #45

Merged
merged 1 commit into from
May 19, 2018
Merged

Add basic Travis CI configuration. #45

merged 1 commit into from
May 19, 2018

Conversation

AlekSi
Copy link
Contributor

@AlekSi AlekSi commented May 19, 2018

Refs #14.

@umputun
Copy link
Owner

umputun commented May 19, 2018

thx for the PR. two questions:

  1. why sudo: required ?
  2. dist: trusty - probably doesn't matter as we use docker build, but still

edit: I guess docker needs sudo on travis. Is this the usual way to run docker build
or they have a docker-friendly way?

@umputun umputun merged commit af7993c into umputun:master May 19, 2018
@AlekSi
Copy link
Contributor Author

AlekSi commented May 20, 2018

This page states that both sudo: required and dist: trusty are not in fact required – the presence of docker commands in install and script is enough. See #46 for example.
But I would keep configuration as it is now. This and this pages both state that those lines are required. Otherwise, the build could be routed to container-based infrastructure. I think those pages are just outdated. But Travis CI does change defaults and routing rules from time to time, so I would keep things explicit as they are now.

Is this the usual way to run docker build or they have a docker-friendly way?

That's the recommended way. They optimize for building with a set of bash commands. If it does not requires Docker (or explicitly requires full VM for some reason) they have a flexibility of routing a build to a less loaded infrastructure.

@paskal paskal added this to the v1.3 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants