Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image RPC #625

Merged
merged 3 commits into from Apr 4, 2020
Merged

Image RPC #625

merged 3 commits into from Apr 4, 2020

Commits on Apr 3, 2020

  1. Copy the full SHA
    6eabb9c View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    1a4e4b6 View commit details
    Browse the repository at this point in the history
  3. fix memory_storage run

    - add proper formatting to Readme instructions
    - fix docker-compose yaml
    - add Enabled flag to admin storage, as without it I saw following error on trying to post a comment:
      ```
      mem_store.r42    | 2020/04/03 15:53:52.433 [INFO]  {logger/logger.go:120 logger.(*Middleware).Handler.func1.1} POST - /cmd - 172.20.0.3 - 200 (25) - 126.8µs - {"method":"admin.enabled","params":"remark","id":29}
      remark42         | 2020/04/03 15:53:52.434 [WARN]  {rest/httperrors.go:85 rest.SendErrorJSON} can't save comment - failed to prepare comment: can't get secret for site remark: site remark disabled - 500 (0) - dev_user/dev_user - /api/v1/comment - [rest/api/rest_private.go:121 api.(*private).createCommentCtrl]
      ```
      Flag was originally added 106c018
    paskal committed Apr 3, 2020
    Copy the full SHA
    2edf0e5 View commit details
    Browse the repository at this point in the history