Allow cross site requests #841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to allow cross site requests if comments are hosted on different domain/subdomain. Details on the setting: https://golang.org/pkg/net/http/#SameSite Change as proposed in umputun#784
Pull Request Test Coverage Report for Build 463583413
💛 - Coveralls |
umputun
requested changes
Jan 5, 2021
There was a problem hiding this comment.
This is vednored directory. We don't want to change it because the next update of go-pkgz/auth will wipe it out. The change should be submitted to https://github.com/go-pkgz/auth
|
I opened an issue go-pkgz/auth#73 I might give it try, so it does not end up in the backlog. |
|
this was done by #850 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to allow cross site requests if comments are hosted on different domain/subdomain.
Details on the setting: https://golang.org/pkg/net/http/#SameSite
Change as proposed in #784