Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the ability to configure the 'simple_view' parameter from the cli… #963

Merged

Conversation

Yuriy-Karpov
Copy link

@Yuriy-Karpov Yuriy-Karpov commented Apr 30, 2021

added the ability to configure the 'simple_view' parameter from the client,
the parameter is not required, but if set, it will overwrite the one that came from the backend
#916

@akellbl4
Copy link
Collaborator

@Yuriy-Karpov Hey! Thank you for contributing to the project.
You've done a quite big job and it works as well, very nice. But I don't think so we need a such merger just to merge one parameter into config.

frontend/app/remark.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #963 (4198ab4) into master (befb079) will increase coverage by 0.14%.
The diff coverage is 64.28%.

❗ Current head 4198ab4 differs from pull request most recent head 4dcba85. Consider uploading reports for the commit 4dcba85 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
+ Coverage   43.15%   43.29%   +0.14%     
==========================================
  Files         127      128       +1     
  Lines        2621     2633      +12     
  Branches      519      522       +3     
==========================================
+ Hits         1131     1140       +9     
- Misses       1444     1447       +3     
  Partials       46       46              
Impacted Files Coverage Δ
frontend/app/remark.tsx 0.00% <0.00%> (ø)
frontend/app/utils/parseQuery.ts 100.00% <ø> (ø)
...ontend/app/utils/parse-booleans-from-dictionary.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update befb079...4dcba85. Read the comment docs.

akellbl4
akellbl4 previously approved these changes Apr 30, 2021
Copy link
Collaborator

@akellbl4 akellbl4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umputun
Copy link
Owner

umputun commented Apr 30, 2021

Thx. Could you, pls rebase those commits into one? I can squash it, but as far as I recall it will show the result under my name, which is confusing

@paskal
Copy link
Sponsor Collaborator

paskal commented May 4, 2021

@Yuriy-Karpov gentle ping: as soon as you'll rebase\squash everything into a single commit, it will be merged and likely will get into release v1.8.0.

@Yuriy-Karpov
Copy link
Author

I apologize for the late response, I will do everything now

…ent,

the parameter is not required, but if set, it will overwrite the one that came from the backend
issues-916
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@umputun umputun merged commit 4e0a4e5 into umputun:master May 6, 2021
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants