Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace module classnames to faster and smaller clsx #973

Merged
merged 2 commits into from
May 6, 2021

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented May 5, 2021

A simple replace classnames to clsx
clsx is smaller and faster version of classnames.
Also, classnames/bind was rid of from the project.

@akellbl4 akellbl4 requested a review from Mavrin May 5, 2021 07:29
@akellbl4 akellbl4 changed the title replace classnames to faster and smaller package replace module classnames to faster and smaller clsx May 5, 2021
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #973 (88ab267) into master (82f8f6c) will increase coverage by 0.01%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
+ Coverage   43.17%   43.18%   +0.01%     
==========================================
  Files         127      127              
  Lines        2622     2619       -3     
  Branches      519      520       +1     
==========================================
- Hits         1132     1131       -1     
+ Misses       1444     1442       -2     
  Partials       46       46              
Impacted Files Coverage Δ
frontend/app/components/input/index.ts 100.00% <ø> (ø)
...end/app/components/list-comments/list-comments.tsx 0.00% <0.00%> (ø)
frontend/app/components/root/root.tsx 0.00% <0.00%> (ø)
frontend/app/components/auth/auth.tsx 86.66% <100.00%> (ø)
frontend/app/components/auth/components/button.tsx 100.00% <100.00%> (ø)
frontend/app/components/auth/components/oauth.tsx 100.00% <100.00%> (ø)
...tend/app/components/comment-form/text-expander.tsx 18.60% <100.00%> (+0.82%) ⬆️
frontend/app/components/input/input.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d361564...88ab267. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 5, 2021

size-limit report 📦

Path Size
public/embed.mjs 2.28 KB (0%)
public/remark.mjs 67.22 KB (-0.23% 🔽)
public/remark.css 10.62 KB (0%)
public/last-comments.mjs 31.04 KB (-0.19% 🔽)
public/last-comments.css 5.76 KB (0%)
public/deleteme.mjs 10.11 KB (0%)
public/counter.mjs 626 B (0%)

@akellbl4 akellbl4 force-pushed the replace-classnames-to-clsx branch from 50a22d5 to 88ab267 Compare May 5, 2021 19:30
@akellbl4 akellbl4 marked this pull request as ready for review May 5, 2021 19:32
@akellbl4 akellbl4 requested a review from umputun as a code owner May 5, 2021 19:32
@umputun umputun merged commit 1ee571a into master May 6, 2021
@umputun umputun deleted the replace-classnames-to-clsx branch May 6, 2021 20:11
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants