Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type module while load modern js bundle #976

Merged
merged 1 commit into from
May 6, 2021
Merged

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented May 5, 2021

Now we have two requests for the js bundle because we don't add type="module" when requesting it.
This PR is fixing it.

@akellbl4 akellbl4 requested a review from Mavrin May 5, 2021 17:11
@akellbl4 akellbl4 requested a review from umputun as a code owner May 5, 2021 17:11
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #976 (04f59b6) into master (4e0a4e5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #976   +/-   ##
=======================================
  Coverage   43.31%   43.31%           
=======================================
  Files         128      128           
  Lines        2634     2634           
  Branches      522      522           
=======================================
  Hits         1141     1141           
  Misses       1447     1447           
  Partials       46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e0a4e5...04f59b6. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 5, 2021

size-limit report 📦

Path Size
public/embed.mjs 2.28 KB (0%)
public/remark.mjs 67.44 KB (0%)
public/remark.css 10.62 KB (0%)
public/last-comments.mjs 31.09 KB (0%)
public/last-comments.css 5.76 KB (0%)
public/deleteme.mjs 10.11 KB (0%)
public/counter.mjs 626 B (0%)

Mavrin
Mavrin previously approved these changes May 6, 2021
@umputun
Copy link
Owner

umputun commented May 6, 2021

conflict pls?

@umputun umputun merged commit 928be7d into master May 6, 2021
@umputun umputun deleted the add-module-type branch May 6, 2021 20:08
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants