Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make classnames short #980

Merged
merged 1 commit into from
May 6, 2021
Merged

make classnames short #980

merged 1 commit into from
May 6, 2021

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented May 5, 2021

I've got the idea here and reimplemented it in our project in favor of reducing JS and CSS bundle size as well.

UPD. When we fully migrate on CSS Modules size of JS and CSS should drop due to using this shorting mechanism.

@akellbl4 akellbl4 added this to the v1.9 milestone May 5, 2021
@akellbl4 akellbl4 requested a review from Mavrin May 5, 2021 19:18
@akellbl4 akellbl4 requested a review from umputun as a code owner May 5, 2021 19:18
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #980 (e193633) into master (82f8f6c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #980   +/-   ##
=======================================
  Coverage   43.17%   43.17%           
=======================================
  Files         127      127           
  Lines        2622     2622           
  Branches      519      519           
=======================================
  Hits         1132     1132           
  Misses       1444     1444           
  Partials       46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e841bc2...e193633. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 5, 2021

size-limit report 📦

Path Size
public/embed.mjs 2.25 KB (-1.25% 🔽)
public/remark.mjs 67.05 KB (-0.48% 🔽)
public/remark.css 10.07 KB (-5.18% 🔽)
public/last-comments.mjs 31.06 KB (-0.12% 🔽)
public/last-comments.css 5.72 KB (-0.82% 🔽)
public/deleteme.mjs 10.09 KB (-0.24% 🔽)
public/counter.mjs 601 B (-4% 🔽)

@umputun umputun merged commit b3beca1 into master May 6, 2021
@umputun umputun deleted the shorten-classnames branch May 6, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants