Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use named exports #982

Merged
merged 1 commit into from
May 6, 2021
Merged

use named exports #982

merged 1 commit into from
May 6, 2021

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented May 5, 2021

I noticed an inconsistency when modules are using default naming. Even I sometimes rename imported module and then it's hard to read or refactor code. Here are other reasons why it's good.
I tried to use named imports and check if it makes an impact on bundle size and it's not.

@github-actions
Copy link

github-actions bot commented May 5, 2021

size-limit report 📦

Path Size
public/embed.mjs 2.25 KB (0%)
public/remark.mjs 65.33 KB (+0.03% 🔺)
public/remark.css 10.07 KB (0%)
public/last-comments.mjs 30.07 KB (-0.03% 🔽)
public/last-comments.css 5.72 KB (0%)
public/deleteme.mjs 9.71 KB (0%)
public/counter.mjs 601 B (0%)

@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #982 (81d382a) into master (123cd53) will increase coverage by 0.13%.
The diff coverage is 54.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
+ Coverage   43.85%   43.98%   +0.13%     
==========================================
  Files         129      127       -2     
  Lines        2921     2903      -18     
  Branches      657      662       +5     
==========================================
- Hits         1281     1277       -4     
+ Misses       1627     1613      -14     
  Partials       13       13              
Impacted Files Coverage Δ
frontend/app/common/api.getLastComments.ts 0.00% <0.00%> (ø)
frontend/app/common/copy.ts 0.00% <0.00%> (ø)
frontend/app/common/user-info-settings.ts 0.00% <0.00%> (ø)
frontend/app/components/auth-panel/index.ts 0.00% <0.00%> (ø)
frontend/app/components/auth/auth.utils.ts 86.66% <ø> (ø)
.../comment-form/markdown-toolbar-icons/bold-icon.tsx 33.33% <0.00%> (ø)
.../comment-form/markdown-toolbar-icons/code-icon.tsx 33.33% <0.00%> (ø)
...omment-form/markdown-toolbar-icons/header-icon.tsx 33.33% <0.00%> (ø)
...comment-form/markdown-toolbar-icons/image-icon.tsx 33.33% <0.00%> (ø)
...omment-form/markdown-toolbar-icons/italic-icon.tsx 33.33% <0.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 123cd53...81d382a. Read the comment docs.

@akellbl4 akellbl4 marked this pull request as ready for review May 5, 2021 22:28
@akellbl4 akellbl4 requested a review from umputun as a code owner May 5, 2021 22:28
@akellbl4 akellbl4 requested a review from Mavrin May 5, 2021 22:29
Mavrin
Mavrin previously approved these changes May 6, 2021
Copy link
Collaborator

@Mavrin Mavrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@umputun
Copy link
Owner

umputun commented May 6, 2021

another conflict

@akellbl4
Copy link
Collaborator Author

akellbl4 commented May 6, 2021

We need to merge #894 because it could increase the number of the conflicts and fix them after it.

@umputun umputun merged commit d8058c6 into master May 6, 2021
@umputun umputun deleted the named-exports branch May 6, 2021 20:55
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants