Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mobile navigation to comment for hidden comments #983

Merged
merged 1 commit into from
May 19, 2021

Conversation

Yuriy-Karpov
Copy link

@Yuriy-Karpov Yuriy-Karpov commented May 6, 2021

Issue #82

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #983 (f3fcddc) into master (82f8f6c) will increase coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
+ Coverage   43.17%   43.30%   +0.12%     
==========================================
  Files         127      128       +1     
  Lines        2622     2635      +13     
  Branches      519      521       +2     
==========================================
+ Hits         1132     1141       +9     
- Misses       1444     1448       +4     
  Partials       46       46              
Impacted Files Coverage Δ
frontend/app/components/root/root.tsx 0.00% <0.00%> (ø)
frontend/app/remark.tsx 0.00% <0.00%> (ø)
...ontend/app/utils/parse-booleans-from-dictionary.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e841bc2...f3fcddc. Read the comment docs.

@akellbl4
Copy link
Collaborator

akellbl4 commented May 6, 2021

Looks good, I'll spin it tomorrow.

@akellbl4 akellbl4 added this to the v1.9 milestone May 6, 2021
Copy link
Collaborator

@akellbl4 akellbl4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long review.
LGTM ;)

@umputun umputun merged commit 6f10a5a into umputun:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants