replace deprecated golangci-lint check, fix goleak reports #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskal
force-pushed
the
paskal/improve_tests
branch
from
520e095
to
b88efd6
Compare
|
maybe we want to change this as well? https://github.com/umputun/remark42/blob/master/backend/.golangci.yml#L78 |
paskal
force-pushed
the
paskal/improve_tests
branch
from
b88efd6
to
9a6d82f
Compare
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that fix running individual tests I changed in that PR produced goleak reports, they are not visible on a full test run likely because enough time passes for the client to die on its own.