Renew image time to cleanup on comment Preview and Submit

[paskal]

That PR will delay the image clean up after it's loaded by preview, so the commenter would have more time to post it before cleanup removes it.

Also, reset the cleanup time on images in the submitted comment to prevent the situation when they are deleted from temporary storage before being move to the permanent one, waiting for comment EditDuration to expire. That resolves #909.

[coveralls]

Pull Request Test Coverage Report for Build 853908858

• 26 of 33 (78.79%) changed or added relevant lines in 5 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.03%) to 83.614%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
backend/app/store/image/image.go	6	9	66.67%
backend/app/store/image/bolt_store.go	6	10	60.0%

Totals
Change from base Build 851855721:	-0.03%
Covered Lines:	5419
Relevant Lines:	6481

---

💛 - Coveralls

[umputun]

I see what you did and this solution can probably work but there are a couple of things I don't like:

• the idea to make this countdown reset a part of storage feels odd. This is some kind of temporary state and keeping it in the real long-term store gives us only one benefit - the ability to survive reboots and, as a nice side effect, distributed mode (if the store supports it). I don't think we really care about the first one, and for the second - some sort of cache seems to be a closer match
• The implementation not insanely complex but still too much for what we are trying to achieve here.

as I opened the ticket my idea was to isolate all of it on the image and service levels. i.e. some sort of event bus from rest to image communicating change event. I'm not sure if this even possible as I have not tried to write the actual code, just a feeling. Maybe moving this countdown store closer to the image will do it

[paskal]

If the staging storage is part of the image.Store interface as it is now, we can't alter its commit and cleanup behaviour other than the way I did it above. The only way around is I can think of is implementing separate staging storage for images that will be independent of the normal one, then we'll have commit and cleanup and cleanup timer reset functionality in that separate package and not in three of them as of now.

What do you think?

[codecov]

Codecov Report

Merging #992 (3211079) into master (cbdf5f1) will increase coverage by 0.01%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
+ Coverage   43.99%   44.01%   +0.01%     
==========================================
  Files         127      127              
  Lines        2905     2906       +1     
  Branches      656      657       +1     
==========================================
+ Hits         1278     1279       +1     
  Misses       1614     1614              
  Partials       13       13              

Impacted Files	Coverage Δ
frontend/app/components/user-info/user-info.tsx	0.00% <0.00%> (ø)
frontend/app/components/avatar/avatar.tsx	100.00% <100.00%> (ø)
frontend/app/components/avatar/index.ts	100.00% <100.00%> (ø)
frontend/app/components/comment/comment.tsx	64.85% <100.00%> (-0.12%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d011aa...3211079. Read the comment docs.

[umputun]

LGTM