Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional resource check and failback #6

Merged
merged 4 commits into from
Jan 2, 2022
Merged

Add optional resource check and failback #6

merged 4 commits into from
Jan 2, 2022

Conversation

umputun
Copy link
Owner

@umputun umputun commented Jan 2, 2022

the goal is to eliminate redirects to a node without the actual resource. the current version expects all nodes to have all the resources, and a not-found redirect is supposed to be handled by the node itself.

this PR adds an optional HEAD request prior to the final redirect and failed request will change the redirect to failback url + requested resource

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1647223807

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.7%) to 86.667%

Totals Coverage Status
Change from base Build 1647216784: 2.7%
Covered Lines: 221
Relevant Lines: 255

💛 - Coveralls

@umputun umputun merged commit 1b563cf into master Jan 2, 2022
@umputun umputun deleted the failback branch January 2, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants