Skip to content

Commit

Permalink
add a comment clarifying why join is not used
Browse files Browse the repository at this point in the history
  • Loading branch information
umputun committed Jul 27, 2023
1 parent 2839a1a commit 3f6d61f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pkg/runner/commands.go
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ func (ec *execCmd) Copy(ctx context.Context) (resp execCmdResp, err error) {
// if sudo is set, we need to upload the file to a temporary directory and move it to the final destination
tmpRemoteDir := ec.uniqueTmp(tmpRemoteDirPrefix)
resp.details = fmt.Sprintf(" {copy: %s -> %s, sudo: true}", src, dst)
// not using filepath.Join because we want to keep the linux slash, see https://github.com/umputun/spot/issues/144
tmpDest := tmpRemoteDir + "/" + filepath.Base(dst)

// upload to a temporary directory with mkdir
Expand Down

0 comments on commit 3f6d61f

Please sign in to comment.