Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not select the default key with --ssh=agent #171

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

olegmlsn
Copy link
Contributor

should address #170

If no ssh key is specified and the --ssh-agent option is specified, do not select the default key

Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. a small thing what is missing - a small test case for the change

cmd/spot/main_test.go Show resolved Hide resolved
@umputun
Copy link
Owner

umputun commented Feb 13, 2024

re: linter thing - I have updated master, pls rebase your branch and it should pass

@coveralls
Copy link

coveralls commented Feb 13, 2024

Pull Request Test Coverage Report for Build 7890943636

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 84.427%

Totals Coverage Status
Change from base Build 7795981426: 0.01%
Covered Lines: 2651
Relevant Lines: 3140

💛 - Coveralls

@umputun umputun self-requested a review February 13, 2024 18:18
@umputun
Copy link
Owner

umputun commented Feb 13, 2024

LGTM, thx

@umputun umputun merged commit 31e622d into umputun:master Feb 13, 2024
1 check passed
@olegmlsn olegmlsn deleted the no_default_key branch February 13, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants