add support for task-level options propagated to all commands #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the initial goal was to allow setting task-level secrets, however, to keep things consistent with other options it was extended to support all the options. The solution has a limitation and command options can't reset boolean options defined on task level. This is because we don't have a way to distinguish between default values (i.e. false for bool) and false set for real.
Deploying spot-site with
|
| Latest commit: |
c4db01c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://10a9f049.spot-7ki.pages.dev |
| Branch Preview URL: | https://task-secret.spot-7ki.pages.dev |
Pull Request Test Coverage Report for Build 8397713130Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial goal was to allow setting task-level secrets; however, to keep things consistent with other options, it was extended to support all the options. The solution is limited, and command options can't reset the boolean options defined at the task level. This is because we don't have a way to distinguish between default values (i.e. false for bool) and false set for real.
This PR also addresses concerns mentioned by @rahfar in #179 and allows the setting of secrets on the task level, once for all the commands and onerror