Secret masking improvements #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in colorized log if a Printf used This commit implements the masking of secrets in logger output and revises how debugging is set up, with a focus on logs involving secrets. The secrets are made available only after the playbook is loaded, and they're now passed as parameters to setupLog function. Relevant tests were updated and an additional test case for Printf function with secrets was added.
Deploying spot-site with
|
| Latest commit: |
4402a87
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1b0d8045.spot-7ki.pages.dev |
| Branch Preview URL: | https://hide-secrets.spot-7ki.pages.dev |
Pull Request Test Coverage Report for Build 8403979176Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce masking of secrets in internal logger. Also enforce masking in colorized log if
Printfused.This PR implements the masking of secrets in logger output and revises how debugging is set up, with a focus on logs involving secrets. The secrets are made available only after the playbook is loaded, and they're now passed as parameters to setupLog function. Relevant tests were updated and an additional test case for Printf function with secrets was added.
see #181