Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed --file to --playbook #29

Closed
wants to merge 1 commit into from
Closed

Renamed --file to --playbook #29

wants to merge 1 commit into from

Conversation

bessarabov
Copy link
Contributor

This is a matter of taste, but I think that this change makes the project a bit better.

Here is the currect interface of spot:

$ spot_0_7_2 --help
simplotask v0.7.2-7ad5d3d-2023-05-01T08:54:45Z
Usage:
  spot_0_7_2

Application Options:
  -p, --file=           playbook file (default: spot.yml) [$SPOT_FILE]
...
      --inventory-file= inventory file [$SPOT_INVENTORY]
...

Here I did the changes

  • --file => --playbook. This make long option playbook consistent with the short option p
  • $SPOT_FILE => $SPOT_PLAYBOOK. This makes it play well with the other env variable $SPOT_INVENTORY

@bessarabov bessarabov requested a review from umputun as a code owner May 1, 2023 13:48
@bessarabov
Copy link
Contributor Author

Hmm. Not sure that I understand why the CI failed.

@bessarabov
Copy link
Contributor Author

I did a force push to my branch (no changes to the code, but some changes in metadata of the commit) to re-run the CI. And now the CI passed all the steps without the erros.

I don't understand why the first CI run failed ( https://github.com/umputun/simplotask/actions/runs/4851676409 ), but I don't think that this matter much.

@umputun
Copy link
Owner

umputun commented May 1, 2023

Can you pls rebase with the current master and resolve the conflict?

@bessarabov bessarabov closed this by deleting the head repository May 2, 2023
@bessarabov
Copy link
Contributor Author

I see that you have changed the name of the repo from simplotask to spot (and I"m very happy with this change), so I've deleted my existing fork bessarabov/simplotask to create new fork bessarabov/spot. But the deletion of my fork lead to the auto close of this PR.

The new PR on this topic is #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants