simple sudo implementation #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
script command only support sudo, at least for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #60 and introduces the
options.sudofield, allowing users to runscriptcommands with elevated privileges. However, this implementation is limited, as enabling sudo forcopyandmcopycommands is significantly more complex. It would require copying files to a temporary location and then executing a move command to transfer them to their final destination. Additionally, supporting glob patterns further complicates the task. Implementing sudo for the sync command is unclear, and how this could be achieved is not immediately apparent.Considering these limitations, restricting the
sudooption to thescriptcommand type is a reasonable trade-off. If users need to deploy substantial resources to root-only locations, using the root user directly is likely more efficient.