Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix network monitor to use Mbps and search for available ethernet interfaces #432

Merged
merged 6 commits into from
Apr 24, 2023

Conversation

tabiosg
Copy link
Contributor

@tabiosg tabiosg commented Apr 11, 2023

Summary

none

What features did you add, bugs did you fix, etc?

Did you add documentation to the wiki?

never

How was this code tested?

roslaunch mrover basestation.launch

Copy link
Contributor

@CameronTressler CameronTressler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have to change the yaml to work with different laptops

config/esw.yaml Outdated
@@ -292,4 +292,4 @@ brushless:
max_torque: 0.13
multiplier: -1

network_iface: "enp44s0"
network_iface: "enp0s31f6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to do something like this in network_monitor.py

import os iface_list = os.list_dir('/sys/class/net/')
And then check for an interface that starts with enp

@edurso edurso changed the title Update config for Rocker laptop and change network monitor to Mbps Fix network monitor to use Mbps and search for available ethernet interfaces Apr 20, 2023
Copy link
Contributor

@CameronTressler CameronTressler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be slightly safer to use startswith() to check for values that start with e instead of [:1] but I don't think we could get an empty string so I don't care too much. Could be worth the extra commit if you want but I won't block on it

@tabiosg tabiosg merged commit 7416bce into master Apr 24, 2023
@tabiosg tabiosg deleted the guts/network-fix branch April 24, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants