Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum Viable Product #1

Merged
merged 33 commits into from
Aug 16, 2023
Merged

Minimum Viable Product #1

merged 33 commits into from
Aug 16, 2023

Conversation

benmelz
Copy link
Member

@benmelz benmelz commented Aug 15, 2023

See README for big picture, JSDoc for details

TODO:

  • implement ci
  • implement cd
  • update PRODUCTION_URL placeholders
  • setup build user/give travis a PAT

Copy link
Member

@werebus werebus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might not be a bad idea to have someone who knows anything at all about React look at it to confirm that you're doing it right, but here's what I've got.

src/hooks/usePublicMessages.js Show resolved Hide resolved
src/App.jsx Outdated Show resolved Hide resolved
src/hooks/usePublicMessages.js Outdated Show resolved Hide resolved
src/components/PublicMessage.module.css Show resolved Hide resolved
src/components/PublicMessage.jsx Outdated Show resolved Hide resolved
src/components/PublicMessage.jsx Outdated Show resolved Hide resolved
@benmelz
Copy link
Member Author

benmelz commented Aug 15, 2023

Might not be a bad idea to have someone who knows anything at all about React look at it to confirm that you're doing it right

any chance @Anbranin is willing to make a celebrity guest appearance?
if not @frothedoatmilk indicated he has the slightest bit of react experience

src/hooks/usePublicMessages.js Show resolved Hide resolved
src/components/PublicMessage.jsx Outdated Show resolved Hide resolved
src/components/PublicMessageBoard.module.css Outdated Show resolved Hide resolved
@frothedoatmilk
Copy link
Contributor

Oh how I wish the SortOrder in the rest API sorted alphabetically...

Copy link
Contributor

@frothedoatmilk frothedoatmilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only things I have left are:

  • Mention running npm install as part of setup for a dev environment in README
  • I think the border on the table should be a darker color

But both of those are pretty nitpicky and tbh don't matter that much

@benmelz
Copy link
Member Author

benmelz commented Aug 16, 2023

  • Mention running npm install as part of setup for a dev environment in README

Yeah you're probably right, I was banking on it being implicit but that's probably wishful thinking

  • I think the border on the table should be a darker color

It's actually another piece ripped from bootstrap, so I think I'd rather stick with it

Copy link
Member

@werebus werebus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I "verified" pvta-public-messages.admin.umass.edu in Infoblox/GitHub just now, FYI. Just need to add the CNAME.

.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
src/index.css Show resolved Hide resolved
@benmelz benmelz merged commit 63ec722 into main Aug 16, 2023
1 check passed
@benmelz benmelz deleted the initial-dev branch August 16, 2023 17:57
benmelz added a commit that referenced this pull request Aug 16, 2023
@benmelz benmelz mentioned this pull request Aug 16, 2023
benmelz added a commit that referenced this pull request Sep 1, 2023
As discussed in #1, some messages affect multiple routes. Displaying
them multiple times is undesired, so to fix #4, we'll group any routes
affected by one message under that message.

---------

Co-authored-by: benmelz <ben@melz.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants