-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimum Viable Product #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might not be a bad idea to have someone who knows anything at all about React look at it to confirm that you're doing it right, but here's what I've got.
any chance @Anbranin is willing to make a celebrity guest appearance? |
Oh how I wish the SortOrder in the rest API sorted alphabetically... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only things I have left are:
- Mention running
npm install
as part of setup for a dev environment in README - I think the border on the table should be a darker color
But both of those are pretty nitpicky and tbh don't matter that much
Yeah you're probably right, I was banking on it being implicit but that's probably wishful thinking
It's actually another piece ripped from bootstrap, so I think I'd rather stick with it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I "verified" pvta-public-messages.admin.umass.edu
in Infoblox/GitHub just now, FYI. Just need to add the CNAME.
See README for big picture, JSDoc for details
TODO:
PRODUCTION_URL
placeholders