Merge pull request #25 from RaidOuahioune/RaidOuahioune-patch-1-1

fix quering from the source model && hardcoded target type
umutphp · Nov 22, 2023 · 1e11e87 · 1e11e87
2 parents d005c2d + 2a1a379
commit 1e11e87
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/HasRecommendation.php b/src/HasRecommendation.php
@@ -301,19 +301,20 @@ public static function calculateSimilarityMatrix($models, $config): array
     public function getRecommendations($name)
     {
         $config = $this->getRecommendationConfig()[$name] ?? null;
+        $model=$config['recommendation_data_field_type']??self::class;
 
         if ($config === null) {
             return [];
         }
 
         $recommendations = RecommendationsModel::where('source_type', self::class)
             ->where('recommendation_name', $name)
-            ->where('target_type', self::class)
+            ->where('target_type', $model)
             ->where('source_id', $this->id)
             ->get();
 
 
-        $return = $this->whereIn('id', $recommendations->pluck('target_id'))->get();
+        $return = $model::query()->whereIn('id', $recommendations->pluck('target_id'))->get();
 
         $order = $config['recommendation_order'] ?? config('laravel_model_recommendation.recommendation_count');