Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade minimatch to v9 but it fails on some cases #22

Closed
JounQin opened this issue Dec 18, 2023 · 3 comments
Closed

deps: upgrade minimatch to v9 but it fails on some cases #22

JounQin opened this issue Dec 18, 2023 · 3 comments
Labels
dependency enhancement New feature or request help wanted Extra attention is needed PR welcome

Comments

@JounQin
Copy link
Member

JounQin commented Dec 18, 2023

For anyone may be interested, I just upgraded debug to v4 and removed unused resolve dependencies at v2.29.1. And I tried to upgrade minimatch to v9 but it fails on some cases like

import-js#2900 (comment)

and

https://github.com/import-js/eslint-plugin-import/blob/ee5fadeffff68f2300bed7f67a310496cb969d61/tests/src/rules/no-internal-modules.js

I don't have enough time to work on this replacement, anyone interested can help to raise a PR which will be appreciated.


For import-js#2900 (comment), I think it should be changed to invalid cases instead.

Originally posted by @JounQin in #11 (comment)

@SukkaW
Copy link
Collaborator

SukkaW commented Dec 18, 2023

@JounQin Maybe try micromatch instead?

@JounQin
Copy link
Member Author

JounQin commented Dec 18, 2023

@SukkaW It seems minimatch is better maintained than micromatch? Any benefit by using micromatch instead?


OK, I saw https://www.npmjs.com/package/micromatch#why-use-micromatch

Maybe it worths a try, but not quite sure.

@JounQin
Copy link
Member Author

JounQin commented Mar 12, 2024

close via #38

@JounQin JounQin closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency enhancement New feature or request help wanted Extra attention is needed PR welcome
Projects
None yet
Development

No branches or pull requests

2 participants