Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollup)!: change some variables into functions #357

Merged
merged 2 commits into from Dec 26, 2023
Merged

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Dec 26, 2023

related #330

@JounQin JounQin added enhancement New feature or request breaking perf labels Dec 26, 2023
@JounQin JounQin self-assigned this Dec 26, 2023
Copy link

changeset-bot bot commented Dec 26, 2023

🦋 Changeset detected

Latest commit: 2b12211

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@pkgr/rollup Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Dec 26, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (59ccda9) 100.00% compared to head (2b12211) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #357   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           39        39           
  Branches        14        14           
=========================================
  Hits            39        39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Dec 26, 2023

📊 Package size report   2%↑

File Before After
.changeset/rotten-lemons-switch.md 75 B
packages/rollup/src/config.ts 11.3 kB 0.07%↑11.3 kB
packages/utils/src/helpers.ts 2.7 kB 5%↑2.8 kB
packages/utils/src/monorepo.ts 579 B 19%↑691 B
patches/@1stg+eslint-config+7.0.1.patch 1.8 kB
Total (Includes all files) 108.2 kB 2%↑110.3 kB
Tarball size 26.6 kB 2%↑27.2 kB
Unchanged files
File Size
.changeset/config.json 309 B
.changeset/empty-coats-relate.md 80 B
.changeset/fluffy-jars-exist.md 137 B
.changeset/README.md 510 B
.codesandbox/ci.json 76 B
.editorconfig 161 B
.eslintignore 63 B
.eslintrc 103 B
.gitattributes 35 B
.github/workflows/ci.yml 881 B
.github/workflows/codeql.yml 851 B
.github/workflows/pkg-size.yml 468 B
.github/workflows/release.yml 1.1 kB
.lintstagedrc.cjs 50 B
.nvmrc 6 B
.remarkrc 42 B
.simple-git-hooks.cjs 51 B
.stylelintignore 99 B
.stylelintrc 42 B
CHANGELOG.md 486 B
LICENSE 1.1 kB
package.json 2.2 kB
packages/browser/CHANGELOG.md 13 B
packages/browser/index.ts 4.7 kB
packages/browser/openChrome.applescript 2.5 kB
packages/browser/package.json 969 B
packages/browser/tsconfig.json 159 B
packages/core/CHANGELOG.md 13 B
packages/core/package.json 784 B
packages/core/src/constants.ts 330 B
packages/core/src/helpers.ts 1.5 kB
packages/core/src/index.ts 60 B
packages/core/tsconfig.json 161 B
packages/es-modules/CHANGELOG.md 4.4 kB
packages/es-modules/index.ts 1.4 kB
packages/es-modules/package.json 915 B
packages/es-modules/README.md 1.3 kB
packages/es-modules/test/test.spec.ts 927 B
packages/es-modules/tsconfig.json 139 B
packages/imagemin/CHANGELOG.md 8.1 kB
packages/imagemin/package.json 1.2 kB
packages/imagemin/src/cli.ts 541 B
packages/imagemin/src/index.ts 1.1 kB
packages/imagemin/tsconfig.json 132 B
packages/rollup/CHANGELOG.md 19.3 kB
packages/rollup/package.json 1.4 kB
packages/rollup/shim.d.ts 647 B
packages/rollup/src/cli.ts 3.8 kB
packages/rollup/tsconfig.json 131 B
packages/umd-globals/CHANGELOG.md 5.7 kB
packages/umd-globals/index.ts 1.8 kB
packages/umd-globals/package.json 819 B
packages/umd-globals/README.md 1.1 kB
packages/umd-globals/test/test.spec.ts 1.9 kB
packages/umd-globals/tsconfig.json 139 B
packages/utils/CHANGELOG.md 10.6 kB
packages/utils/package.json 884 B
packages/utils/src/constants.ts 486 B
packages/utils/src/index.ts 117 B
packages/utils/tsconfig.json 161 B
README.md 4.1 kB
tsconfig.base.json 43 B
tsconfig.json 381 B

🤖 This report was automatically generated by pkg-size-action

@JounQin JounQin merged commit c2bd834 into master Dec 26, 2023
25 checks passed
@JounQin JounQin deleted the feat/signature branch December 26, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request perf
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant