Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql-formatter is outdated in prettier-plugin-sql #243

Closed
tim-watcha opened this issue Nov 16, 2022 · 2 comments
Closed

sql-formatter is outdated in prettier-plugin-sql #243

tim-watcha opened this issue Nov 16, 2022 · 2 comments

Comments

@tim-watcha
Copy link
Contributor

in package.json, sql-formatter's version is too low

"sql-formatter": "^10.5.1",

so I couldn't use 'bigquery' as language.
please update it
@tim-watcha tim-watcha changed the title sql-formatter is outdated sql-formatter is outdated in prettier-plugin-sql Nov 16, 2022
@JounQin
Copy link
Member

JounQin commented Nov 16, 2022

PR welcome

@tim-watcha
Copy link
Contributor Author

PR welcome

#244
I could use bigquery as language option properly on my machine, but I'm not an expert about Node.js
Could you please look around what is going on? @JounQin

JounQin added a commit that referenced this issue Feb 23, 2023
@tim-watcha @JounQin
feat: add bigquery option for language; sql-formatter version up for #…
b13b262 
…243 (#244)

Co-authored-by: JounQin <admin@1stg.me>
@JounQin JounQin mentioned this issue Feb 23, 2023
Merged
@JounQin JounQin closed this as completed Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JounQin @tim-watcha