Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add make-synchronized to benchmark test #160

Merged
merged 3 commits into from
Jan 21, 2024

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Jan 21, 2024

I don't really care about the load/initialize time, but will be nice to have data here.

Copy link

changeset-bot bot commented Jan 21, 2024

⚠️ No Changeset found

Latest commit: 84c5a18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codesandbox-ci bot commented Jan 21, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JounQin JounQin marked this pull request as ready for review January 21, 2024 08:07
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69b8dcd) 100.00% compared to head (84c5a18) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #160   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          203       203           
  Branches       101       101           
=========================================
  Hits           203       203           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JounQin
Copy link
Member

JounQin commented Jan 21, 2024

Thanks for the great make-synchronized package! I may refactor the public API accordingly.

@JounQin
Copy link
Member

JounQin commented Jan 21, 2024

On Ubuntu:

┌───────────┬────────────┬──────────────┬───────────────────┬─────────────┬─────────────────┬───────────────────┬────────────────────────┬───────────┬─────────────────┐
│  (index)  │  synckit   │ sync-threads │ perf sync-threads │   deasync   │  perf deasync   │ make-synchronized │ perf make-synchronized │  native   │   perf native   │
├───────────┼────────────┼──────────────┼───────────────────┼─────────────┼─────────────────┼───────────────────┼────────────────────────┼───────────┼─────────────────┤
│ loadTime  │  '9.69ms'  │   '0.99ms'   │  '9.76x slower'   │  '23.67ms'  │ '2.44x faster'  │    '223.27ms'     │    '23.05x faster'     │ '0.55ms'  │ '17.55x slower' │
│  runTime  │ '229.52ms' │ '21238.44ms' │  '92.54x faster'  │ '8203.62ms' │ '35.74x faster' │    '3932.52ms'    │    '17.13x faster'     │ '17.45ms' │ '13.15x slower' │
│ totalTime │ '239.21ms' │ '21239.43ms' │  '88.79x faster'  │ '8227.29ms' │ '34.39x faster' │    '4155.79ms'    │    '17.37x faster'     │ '18.00ms' │ '13.29x slower' │
└───────────┴────────────┴──────────────┴───────────────────┴─────────────┴─────────────────┴───────────────────┴────────────────────────┴───────────┴─────────────────┘
┌───────────┬────────────┬──────────────┬───────────────────┬─────────────┬─────────────────┬───────────────────┬────────────────────────┬───────────┬─────────────────┐
│  (index)  │  synckit   │ sync-threads │ perf sync-threads │   deasync   │  perf deasync   │ make-synchronized │ perf make-synchronized │  native   │   perf native   │
├───────────┼────────────┼──────────────┼───────────────────┼─────────────┼─────────────────┼───────────────────┼────────────────────────┼───────────┼─────────────────┤
│ loadTime  │ '21.56ms'  │   '1.49ms'   │  '14.50x slower'  │  '41.00ms'  │ '1.90x faster'  │     '44.66ms'     │     '2.07x faster'     │ '0.65ms'  │ '32.99x slower' │
│  runTime  │ '266.85ms' │ '20633.65ms' │  '77.32x faster'  │ '4399.59ms' │ '16.49x faster' │    '7973.64ms'    │    '29.88x faster'     │ '18.39ms' │ '14.51x slower' │
│ totalTime │ '288.41ms' │ '20635.13ms' │  '71.55x faster'  │ '4440.59ms' │ '15.40x faster' │    '8018.29ms'    │    '27.80x faster'     │ '19.04ms' │ '15.15x slower' │
└───────────┴────────────┴──────────────┴───────────────────┴─────────────┴─────────────────┴───────────────────┴────────────────────────┴───────────┴─────────────────┘

@JounQin JounQin merged commit 9ed752b into un-ts:main Jan 21, 2024
18 checks passed
@fisker fisker deleted the make-synchronized branch January 21, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants