Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the logic to better handle client IP determination for both routable and private #77

Closed
un33k opened this issue Sep 29, 2021 · 3 comments
Assignees

Comments

@un33k
Copy link
Owner

un33k commented Sep 29, 2021

@sinwoobang I think we might need to update ip.py to reflect the login in the typescript equivalent package.

https://github.com/neekware/fullerstack/blob/main/libs/nax-ipware/README.md

Could you take a look at ipware.ts and do the same thing here?

Thx

@sinwoobang
Copy link
Contributor

I checked it. I will let you know after checking it.

@un33k
Copy link
Owner Author

un33k commented Sep 30, 2021

@danizen Would you be able to also look at the above instruction and raise your own PR to better django-ipware?

I believe the ts version is much superior to the py version.

Be great to see your take on the port of the logic from ts to py.

@un33k
Copy link
Owner Author

un33k commented Sep 30, 2022

closing due to inactivity.

@un33k un33k closed this as completed Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants