This repository has been archived by the owner on Jul 22, 2020. It is now read-only.
Evita hacer cache de total y subtotal. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
En lugar de hacer cache, simplemente calcula cuando no se ha asignado ningún valor, o regresa el valor si éste ya fue seteado. Se cambió las clases Retencion y Traslado para que hereden directamente de la clase ElementoComprobante en lugar de una clase intermedia ya que el uso de la variabe @cadenaOriginal a nivel de clase hace que el método `to_h` de `Comun` falle porque las variables a nivel de clase no se heredan.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
En lugar de hacer cache, simplemente calcula cuando no se ha asignado
ningún valor, o regresa el valor si éste ya fue seteado.
Se cambió las clases Retencion y Traslado para que hereden directamente
de la clase ElementoComprobante en lugar de una clase intermedia ya que
el uso de la variabe @cadenaOriginal a nivel de clase hace que el método
to_hdeComunfalle porque las variables a nivel de clase no seheredan.