Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading error with webpack 5+ #102

Closed
wants to merge 2 commits into from

Conversation

jbbarth
Copy link

@jbbarth jbbarth commented May 12, 2021

When trying to upgrade a Rails app from webpacker 5 to 6 (still in beta but bear with me), I got the following error when launching webpack-dev-server:

ERROR in ./node_modules/@unabridged/motion/javascript/Component.js 19:8-15
Should not import the named export 'version' (imported as 'version') from default-exporting module (only default export is available soon)

It turns out I had to upgrade to webpack 5.x which provokes this error. If I understand the webpacker
README correctly, webpack 5.x is already supposed to be supported in webpacker 5. Unclear to me if
it's the default or if people tend to stick with webpack 4.x at this point.

Imo the change looks safe, but we may want to upgrade to webpack 5 in the test application to be sure.
I tried to do so but got cryptic JS errors, and I'm unsure if you want to support both webpack 4.x and
webpack 5.x in this project. I'm ready to try shaving this yak but I'll happily take your opinion
before doing so ;-)

Thanks!

@jbbarth jbbarth changed the title Fix loading error with webpack 6+ Fix loading error with webpack 5+ May 12, 2021
@jbbarth jbbarth marked this pull request as draft May 12, 2021 09:07
@jbbarth jbbarth force-pushed the fix-webpack-loading-issue branch from bc29bb5 to 15513b9 Compare May 17, 2021 00:58
@jbbarth
Copy link
Author

jbbarth commented May 17, 2021

Fwiw the build is passing except for Ruby 3.0.0 where we're hitting something like mimemagicrb/mimemagic#162

@jbbarth
Copy link
Author

jbbarth commented Oct 27, 2021

Closing this as I won't be able to move forward and I lost interest in making it work (switched job + they're removing Motion at my $OLD_JOB). Feel free to take my code if it helps.

@jbbarth jbbarth closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant