Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading error with webpack 5+ #102

Closed
wants to merge 2 commits into from
Closed

Fix loading error with webpack 5+ #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1f647d
Fix loading error with webpacker 6+
jbbarth May 12, 2021
15513b9
Update mimemagic gem to fix test failures
jbbarth May 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 16 additions & 0 deletions Appraisals
View file
Open in desktop
Expand Up @@ -3,21 +3,37 @@ appraise "rails-5-1" do

# Rails 5 does not have built-in support for ActionCable tests.
gem "action-cable-testing"

# mimemagic releases < 0.3.8 have been yanked from rubygems.org
# because of a license violation problem
gem "mimemagic", "~> 0.3.10"
end

appraise "rails-5-2" do
gem "rails", "~> 5.2.0"

# Rails 5 does not have built-in support for ActionCable tests.
gem "action-cable-testing"

# mimemagic releases < 0.3.8 have been yanked from rubygems.org
# because of a license violation problem
gem "mimemagic", "~> 0.3.10"
end

appraise "rails-6-0" do
gem "rails", "~> 6.0.0"

# mimemagic releases < 0.3.8 have been yanked from rubygems.org
# because of a license violation problem
gem "mimemagic", "~> 0.3.10"
end

appraise "rails-6-1" do
gem "rails", "~> 6.1.0"

# mimemagic releases < 0.3.8 have been yanked from rubygems.org
# because of a license violation problem
gem "mimemagic", "~> 0.3.10"
end

appraise "rails-main" do
Expand Down
1 change: 1 addition & 0 deletions gemfiles/rails_5_1.gemfile
View file
Open in desktop
Expand Up @@ -18,5 +18,6 @@ gem "sqlite3"
gem "appraisal"
gem "rails", "~> 5.1.7"
gem "action-cable-testing"
gem "mimemagic", "~> 0.3.10"

gemspec path: "../"
4 changes: 4 additions & 0 deletions gemfiles/rails_5_1.gemfile.lock
View file
Open in desktop
Expand Up @@ -87,6 +87,9 @@ GEM
mail (2.7.1)
mini_mime (>= 0.1.1)
method_source (1.0.0)
mimemagic (0.3.10)
nokogiri (~> 1)
rake
mini_mime (1.0.2)
minitest (5.14.3)
nio4r (2.5.4)
Expand Down Expand Up @@ -219,6 +222,7 @@ DEPENDENCIES
appraisal
capybara (>= 2.15, < 4.0)
generator_spec
mimemagic (~> 0.3.10)
motion!
pry
puma
Expand Down
1 change: 1 addition & 0 deletions gemfiles/rails_5_2.gemfile
View file
Open in desktop
Expand Up @@ -18,5 +18,6 @@ gem "sqlite3"
gem "appraisal"
gem "rails", "~> 5.2.0"
gem "action-cable-testing"
gem "mimemagic", "~> 0.3.10"

gemspec path: "../"
5 changes: 4 additions & 1 deletion gemfiles/rails_5_2.gemfile.lock
View file
Open in desktop
Expand Up @@ -93,7 +93,9 @@ GEM
marcel (0.3.3)
mimemagic (~> 0.3.2)
method_source (1.0.0)
mimemagic (0.3.5)
mimemagic (0.3.10)
nokogiri (~> 1)
rake
mini_mime (1.0.2)
minitest (5.14.3)
nio4r (2.5.4)
Expand Down Expand Up @@ -229,6 +231,7 @@ DEPENDENCIES
appraisal
capybara (>= 2.15, < 4.0)
generator_spec
mimemagic (~> 0.3.10)
motion!
pry
puma
Expand Down
1 change: 1 addition & 0 deletions gemfiles/rails_6_0.gemfile
View file
Open in desktop
Expand Up @@ -17,5 +17,6 @@ gem "webpacker"
gem "sqlite3"
gem "appraisal"
gem "rails", "~> 6.0.0"
gem "mimemagic", "~> 0.3.10"

gemspec path: "../"
5 changes: 4 additions & 1 deletion gemfiles/rails_6_0.gemfile.lock
View file
Open in desktop
Expand Up @@ -104,7 +104,9 @@ GEM
marcel (0.3.3)
mimemagic (~> 0.3.2)
method_source (1.0.0)
mimemagic (0.3.5)
mimemagic (0.3.10)
nokogiri (~> 1)
rake
mini_mime (1.0.2)
minitest (5.14.3)
nio4r (2.5.4)
Expand Down Expand Up @@ -242,6 +244,7 @@ DEPENDENCIES
appraisal
capybara (>= 2.15, < 4.0)
generator_spec
mimemagic (~> 0.3.10)
motion!
pry
puma
Expand Down
1 change: 1 addition & 0 deletions gemfiles/rails_6_1.gemfile
View file
Open in desktop
Expand Up @@ -17,5 +17,6 @@ gem "webpacker"
gem "sqlite3"
gem "appraisal"
gem "rails", "~> 6.1.0"
gem "mimemagic", "~> 0.3.10"

gemspec path: "../"
5 changes: 4 additions & 1 deletion gemfiles/rails_6_1.gemfile.lock
View file
Open in desktop
Expand Up @@ -108,7 +108,9 @@ GEM
marcel (0.3.3)
mimemagic (~> 0.3.2)
method_source (1.0.0)
mimemagic (0.3.5)
mimemagic (0.3.10)
nokogiri (~> 1)
rake
mini_mime (1.0.2)
minitest (5.14.3)
nio4r (2.5.4)
Expand Down Expand Up @@ -245,6 +247,7 @@ DEPENDENCIES
appraisal
capybara (>= 2.15, < 4.0)
generator_spec
mimemagic (~> 0.3.10)
motion!
pry
puma
Expand Down
4 changes: 3 additions & 1 deletion gemfiles/rails_main.gemfile.lock
View file
Open in desktop
Expand Up @@ -135,7 +135,9 @@ GEM
marcel (0.3.3)
mimemagic (~> 0.3.2)
method_source (1.0.0)
mimemagic (0.3.5)
mimemagic (0.3.10)
nokogiri (~> 1)
rake
mini_mime (1.0.2)
minitest (5.14.3)
nio4r (2.5.4)
Expand Down
3 changes: 2 additions & 1 deletion javascript/Component.js
View file
Open in desktop
Expand Up @@ -2,7 +2,8 @@ import dispatchEvent from './dispatchEvent'
import serializeEvent from './serializeEvent'
import reconcile from './reconcile'

import { version } from '../package.json'
import packageInfo from '../package.json'
const { version } = packageInfo

export default class Component {
constructor (client, element) {
Expand Down