Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs of cancel_{minus,plus} #79

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Update docs of cancel_{minus,plus} #79

merged 1 commit into from
Feb 28, 2022

Conversation

unageek
Copy link
Owner

@unageek unageek commented Feb 28, 2022

No description provided.

@coveralls
Copy link

coveralls commented Feb 28, 2022

Pull Request Test Coverage Report for Build 1908088941

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.666%

Totals Coverage Status
Change from base Build 1907902528: 0.0%
Covered Lines: 2102
Relevant Lines: 2145

💛 - Coveralls

@unageek unageek merged commit fe26a2b into main Feb 28, 2022
@unageek unageek deleted the doc branch February 28, 2022 02:44
/// than or equal to the width of `rhs`. If `self` or `rhs` is
/// unbounded, or such `z` does not exist, returns
/// [`ENTIRE`][Self::ENTIRE].
/// Returns the *unique* interval `z` such that `rhs + z` ⊇ `self`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not a unique interval that satisfies rhs + zself. That's why the norm says the tightest.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow… it's so dumb mistake. Thank you so much for pointing it out! I revert the change now, and I'll ask for your review when I make another change to the doc.

unageek added a commit that referenced this pull request Feb 28, 2022
unageek added a commit that referenced this pull request Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants