rust: rewrite & address #12 #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infinidoge
force-pushed
the
rust/fix-12
branch
2 times, most recently
from
3c6fe7a
to
6f20a12
Compare
Includes the decompositions of the versions in the test case to better debug why the test may be failing.
Infinidoge
force-pushed
the
rust/fix-12
branch
from
6f20a12
to
e36a934
Compare
7 tasks
unascribed
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote the decomposition logic to make the splitting rules a bit more explicit and easy to read.
Additionally, these changes properly handle #12.
Also ran my formatter on the tests and added the decompositions to the test failure text, for better debugging.