Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests on windows, style fixes #14

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

Moth-Tolias
Copy link
Collaborator

  • I own the full rights to my contribution, and agree to release it under the terms of the Creative Commons Zero Public Domain Dedication

@unascribed unascribed merged commit 704e127 into unascribed:trunk Jan 17, 2023
@Moth-Tolias
Copy link
Collaborator Author

wow, that was fast as heck! i didn't even have time to explain the changes.

a question: it seems the unittest utility functions were moved back into a seperate version(unittest) block when you implemented #3. was that intentional?

@unascribed
Copy link
Owner

I didn't implement it (note the commit authorship), so I don't know. In general the library should be as light as possible, so if that's comparable to it being inside an #ifdef UNITTEST then I believe that's desirable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants