csharp: sync v1.1.0 from John-Paul-R/FlexVer
#19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixup packaging * add separate readme to get ride of plaintext-rendered img tag
* v1 * fully non-heap-allocating | Method | Mean | Error | StdDev | Gen0 | Allocated | |---------------------------------- |----------:|----------:|----------:|-------:|----------:| | CompareAll_AV2_StackAlloc_ToArray | 4.066 us | 0.0598 us | 0.0559 us | - | - | | CompareAll_Existing | 29.137 us | 0.5789 us | 0.6434 us | 0.3967 | 33672 B | * merge into main FlexVerComparer * add benchmark harness * fixup comment, formatting * todo * make GetNextVersionComponent a bit more decipherable * less-allocating VersionComponent ToString, why not * update dotsettings for limited code style * fixes/simplifications based on tests/spec * consts for char literals * use `ushort` instead of `int` for numeric bits, since `char` is 2-bytes * minor changes from perf test
* Switch to central build/package management * don't pack benchmarks
John-Paul-R
changed the title
v1.1.0 from John-Paul-R/FlexVer
unascribed
requested changes
Jul 23, 2023
* Use `Rune`s (Unicode codepoint) instead of incorrectly using UTF-16 units * Read benchmark test cases from `test/test_vectors.txt` instead of string literal
unascribed
reviewed
Jul 23, 2023
instead of incorrectly incrementing based on IsHighSurrogate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with some build/packaging details, and reworks the comparer implementation to be faster and make no heap allocations.
Benchmark results, using the version strings in the test harness:
NuGet listing from these build changes: https://www.nuget.org/packages/FlexVer