-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BarrageClock never got released. #21
Comments
I committed a new version 1.8.0, you can try this. |
I have tried the new version(1.8.0).It doesn't work for this issue.And after I checked the codes u committed recently,I couldn't find the commit which fixed this issue.Could u show me the codes or the commit link? |
Which version did you use before? 1.7.0? |
Yes,1.7.0.And I tried the newest codes on branch master after you released version 1.8.0. |
Take a look at my new PR #22 |
this: 5ae4863 which fix a retain cycle in 1.7.0 And the commit was released in 1.8.0 |
Yeah.I fixed the BarrageRenderer retain cycle issue by the same codes. |
Have u got it? |
Does it appear in the demo? |
The demo couldn't reproduce this issue.Because the demo keeps a View Controller as root view controller all the time.And VC keeps BarrageRenderer instance all the time. |
I merged it into master branch. |
OK.I closed this issue. |
Some logic bugs in BarrageClock class.Here is my PR(#20 )
The text was updated successfully, but these errors were encountered: