Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BarrageClock never got released. #21

Closed
ParsifalC opened this issue Jun 1, 2016 · 12 comments
Closed

BarrageClock never got released. #21

ParsifalC opened this issue Jun 1, 2016 · 12 comments

Comments

@ParsifalC
Copy link
Contributor

Some logic bugs in BarrageClock class.Here is my PR(#20 )

@unash
Copy link
Owner

unash commented Jun 1, 2016

I committed a new version 1.8.0, you can try this.

@ParsifalC
Copy link
Contributor Author

I have tried the new version(1.8.0).It doesn't work for this issue.And after I checked the codes u committed recently,I couldn't find the commit which fixed this issue.Could u show me the codes or the commit link?

@unash
Copy link
Owner

unash commented Jun 2, 2016

Which version did you use before? 1.7.0?

@ParsifalC
Copy link
Contributor Author

ParsifalC commented Jun 2, 2016

Yes,1.7.0.And I tried the newest codes on branch master after you released version 1.8.0.
pod 'BarrageRenderer', :git => 'https://github.com/unash/BarrageRenderer.git'

@ParsifalC
Copy link
Contributor Author

Take a look at my new PR #22

@unash
Copy link
Owner

unash commented Jun 2, 2016

this: 5ae4863

which fix a retain cycle in 1.7.0

And the commit was released in 1.8.0

@ParsifalC
Copy link
Contributor Author

Yeah.I fixed the BarrageRenderer retain cycle issue by the same codes.
But this is another issue of BarrageClock.

@ParsifalC
Copy link
Contributor Author

Have u got it?

@unash
Copy link
Owner

unash commented Jun 2, 2016

Does it appear in the demo?

@ParsifalC
Copy link
Contributor Author

The demo couldn't reproduce this issue.Because the demo keeps a View Controller as root view controller all the time.And VC keeps BarrageRenderer instance all the time.

@unash
Copy link
Owner

unash commented Jun 2, 2016

I merged it into master branch.

@ParsifalC
Copy link
Contributor Author

OK.I closed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants